public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: msm: Fix reg ranges and clocks on Glymur
Date: Wed, 04 Mar 2026 07:43:56 +1000	[thread overview]
Message-ID: <review-patch1-20260303-glymur-fix-dp-bindings-reg-clocks-v4-1-1ebd9c7c2cee@oss.qualcomm.com> (raw)
In-Reply-To: <20260303-glymur-fix-dp-bindings-reg-clocks-v4-1-1ebd9c7c2cee@oss.qualcomm.com>

Patch Review

**Commit message**: Clear and well-written. Good explanation of the hardware topology (four controllers, three with 2 streams, one SST). The `Fixes:` and `Cc: stable` tags are appropriate.

**dp-controller.yaml changes**:

The removal of `qcom,glymur-dp` from the existing 2-stream group and addition of a dedicated clause is the right approach. The new constraints match the hardware:
- `reg: minItems: 9, maxItems: 9` — correct for all 9 register blocks (ahb, aux, link, p0–p3, mst2link, mst3link), consistent with `qcom,sa8775p-dp` which has a similar 4-port topology.
- `clocks: minItems: 5, maxItems: 6` — correct for allowing SST (5 clocks) or 2-stream MST (6 clocks, with `stream_1_pixel`).

**Issue — `clocks-names` typo**:

```yaml
+        clocks-names:
+          minItems: 5
+          maxItems: 6
```

The property is defined as `clock-names` (line 101 of the file) and listed in the `required:` section as `clock-names` (line 184). The `clocks-names` used here (with the extra 's') doesn't match any defined property, so this constraint is silently ignored by the schema validator. This is a **pre-existing bug** — the same typo appears in all the other `allOf` clauses in this file — but since you're adding new code, this would be a good opportunity to use the correct name. At minimum it should be `clock-names:` in the new clause. Ideally a follow-up (or inclusion in this patch) would fix the other clauses too.

**qcom,glymur-mdss.yaml changes**:

The example update looks correct:

```yaml
-            displayport-controller@ae90000 {
+            displayport-controller@af54000 {
                 compatible = "qcom,glymur-dp";
-                reg = <0xae90000 0x200>,
-                      <0xae90200 0x200>,
-                      <0xae90400 0x600>,
-                      <0xae91000 0x400>,
-                      <0xae91400 0x400>;
+                reg = <0xaf54000 0x200>,
+                      <0xaf54200 0x200>,
+                      <0xaf55000 0xc00>,
+                      <0xaf56000 0x400>,
+                      <0xaf57000 0x400>,
+                      <0xaf58000 0x400>,
+                      <0xaf59000 0x400>,
+                      <0xaf5a000 0x600>,
+                      <0xaf5b000 0x600>;
```

- Addresses updated from made-up values to actual first-controller addresses.
- Link register block size corrected from `0x600` to `0xc00` (matching the sc7180 example and presumably the actual hardware).
- Four new register blocks added (p2, p3, mst2link, mst3link) to reach the required 9 entries.
- The `@` unit address in the node name matches the first reg entry. Good.

**Summary**: The fix is correct. The only issue is the `clocks-names` → `clock-names` typo that should be corrected before merging.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-03 21:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03  9:03 [PATCH v4] dt-bindings: display: msm: Fix reg ranges and clocks on Glymur Abel Vesa
2026-03-03  9:18 ` Johan Hovold
2026-03-03 21:43 ` Claude review: " Claude Code Review Bot
2026-03-03 21:43 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-03-02  9:58 [PATCH v3 0/2] dt-bindings: display: msm: Fix Glymur DP controller reg ranges and clock Abel Vesa
2026-03-02  9:58 ` [PATCH v3 1/2] dt-bindings: display: msm: Fix reg ranges and clocks on Glymur Abel Vesa
2026-03-03  3:37   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260303-glymur-fix-dp-bindings-reg-clocks-v4-1-1ebd9c7c2cee@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox