public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: uapi: Provide DIV_ROUND_CLOSEST()
Date: Wed, 04 Mar 2026 06:54:47 +1000	[thread overview]
Message-ID: <review-patch1-20260303-rk3588-bgcolor-v8-1-fee377037ad1@collabora.com> (raw)
In-Reply-To: <20260303-rk3588-bgcolor-v8-1-fee377037ad1@collabora.com>

Patch Review

**Status: Looks good**

Clean mechanical refactoring moving `DIV_ROUND_CLOSEST()` to a uapi-accessible location as `__KERNEL_DIV_ROUND_CLOSEST()`.

The switch from `typeof` to `__typeof__` is good practice for uapi headers. The commit message's claim about "building ISO C applications" is slightly loose since the statement expression `({...})` syntax is itself a GCC extension, but `__typeof__` is the correct choice for uapi.

Minor style nit: the replacement alias has no blank line separating it from the next comment block:

```c
+#define DIV_ROUND_CLOSEST __KERNEL_DIV_ROUND_CLOSEST
 /*
  * Same as above but for u64 dividends. divisor must be a 32-bit
```

A blank line between the `#define` and the `/*` comment would improve readability, though this is existing context so may not be worth a respin.

The uapi placement in `include/uapi/linux/const.h` next to the existing `__KERNEL_DIV_ROUND_UP` is appropriate. Tags look solid (Acked-by Andy Shevchenko, Reviewed-by Angelo).

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-03 20:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03 19:24 [PATCH v8 0/4] Introduce BACKGROUND_COLOR DRM CRTC property Cristian Ciocaltea
2026-03-03 19:24 ` [PATCH v8 1/4] uapi: Provide DIV_ROUND_CLOSEST() Cristian Ciocaltea
2026-03-03 20:54   ` Claude Code Review Bot [this message]
2026-03-03 19:24 ` [PATCH v8 2/4] drm: Add CRTC background color property Cristian Ciocaltea
2026-03-03 20:54   ` Claude review: " Claude Code Review Bot
2026-03-03 19:24 ` [PATCH v8 3/4] drm/vkms: Support setting custom background color Cristian Ciocaltea
2026-03-03 20:54   ` Claude review: " Claude Code Review Bot
2026-03-03 19:24 ` [PATCH v8 4/4] drm/rockchip: vop2: " Cristian Ciocaltea
2026-03-03 20:54   ` Claude review: " Claude Code Review Bot
2026-03-03 20:54 ` Claude review: Introduce BACKGROUND_COLOR DRM CRTC property Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260303-rk3588-bgcolor-v8-1-fee377037ad1@collabora.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox