From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: uapi: Provide DIV_ROUND_CLOSEST() Date: Wed, 04 Mar 2026 06:54:47 +1000 Message-ID: In-Reply-To: <20260303-rk3588-bgcolor-v8-1-fee377037ad1@collabora.com> References: <20260303-rk3588-bgcolor-v8-0-fee377037ad1@collabora.com> <20260303-rk3588-bgcolor-v8-1-fee377037ad1@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Looks good** Clean mechanical refactoring moving `DIV_ROUND_CLOSEST()` to a uapi-accessible location as `__KERNEL_DIV_ROUND_CLOSEST()`. The switch from `typeof` to `__typeof__` is good practice for uapi headers. The commit message's claim about "building ISO C applications" is slightly loose since the statement expression `({...})` syntax is itself a GCC extension, but `__typeof__` is the correct choice for uapi. Minor style nit: the replacement alias has no blank line separating it from the next comment block: ```c +#define DIV_ROUND_CLOSEST __KERNEL_DIV_ROUND_CLOSEST /* * Same as above but for u64 dividends. divisor must be a 32-bit ``` A blank line between the `#define` and the `/*` comment would improve readability, though this is existing context so may not be worth a respin. The uapi placement in `include/uapi/linux/const.h` next to the existing `__KERNEL_DIV_ROUND_UP` is appropriate. Tags look solid (Acked-by Andy Shevchenko, Reviewed-by Angelo). --- --- Generated by Claude Code Patch Reviewer