public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: soc: imx93-media-blk-ctrl: Add PDFC subnode to schema and example
Date: Wed, 04 Mar 2026 07:36:19 +1000	[thread overview]
Message-ID: <review-patch1-20260303-v6-18-topic-imx93-parallel-display-v11-1-1b03733c8461@pengutronix.de> (raw)
In-Reply-To: <20260303-v6-18-topic-imx93-parallel-display-v11-1-1b03733c8461@pengutronix.de>

Patch Review

This patch adds the `dpi-bridge` subnode schema and a binding example.

**Observations:**

The binding looks well-structured. It properly references `graph.yaml` and `video-interfaces.yaml` for ports and endpoint properties. The `bus-width` enum restricts to valid values `[16, 18, 24]` and the documentation explains the truncation behavior clearly.

One minor question: the binding defines both `nxp,imx91-pdfc` and `nxp,imx93-pdfc` as compatible strings, but the driver (patch 2) only matches `nxp,imx93-pdfc`. The DTS (patch 3) uses `nxp,imx93-pdfc` in the common dtsi for both SoCs. If the imx91 compatible is intended for future use, that's fine, but if someone were to use `nxp,imx91-pdfc` in a device tree today, the driver would not probe. It would be cleaner to either add `nxp,imx91-pdfc` to the driver's `of_device_id` table now, or document that imx91 should use a fallback compatible pair.

No issues with the binding schema itself.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-03 21:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03 10:34 [PATCH v11 0/3] Add i.MX91/93 parallel display support Marco Felsch
2026-03-03 10:34 ` [PATCH v11 1/3] dt-bindings: soc: imx93-media-blk-ctrl: Add PDFC subnode to schema and example Marco Felsch
2026-03-03 21:00   ` Frank Li
2026-03-03 21:36   ` Claude Code Review Bot [this message]
2026-03-03 10:34 ` [PATCH v11 2/3] drm/bridge: imx: Add i.MX93 parallel display format configuration support Marco Felsch
2026-03-03 21:00   ` Frank Li
2026-03-03 21:22     ` Marco Felsch
2026-03-03 21:36   ` Claude review: " Claude Code Review Bot
2026-03-03 10:34 ` [PATCH v11 3/3] arm64: dts: imx93: Add parallel display output nodes Marco Felsch
2026-03-03 10:42   ` Marco Felsch
2026-03-03 15:45     ` Frank Li
2026-03-03 15:50       ` Marco Felsch
2026-03-03 21:36   ` Claude review: " Claude Code Review Bot
2026-03-03 21:36 ` Claude review: Add i.MX91/93 parallel display support Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-02 16:10 [PATCH v10 0/3] " Marco Felsch
2026-03-02 16:10 ` [PATCH v10 1/3] dt-bindings: soc: imx93-media-blk-ctrl: Add PDFC subnode to schema and example Marco Felsch
2026-03-03  3:09   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260303-v6-18-topic-imx93-parallel-display-v11-1-1b03733c8461@pengutronix.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox