public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: Include ioctl.h in UAPI header
Date: Tue, 03 Mar 2026 12:44:02 +1000	[thread overview]
Message-ID: <review-patch1-20260303002309.1401849-1-isaacmanjarres@google.com> (raw)
In-Reply-To: <20260303002309.1401849-1-isaacmanjarres@google.com>

Patch Review

**Correctness:** The patch is correct. The file uses `_IOW` and `_IOWR` macros:

```c
#define DMA_BUF_IOCTL_SYNC	_IOW(DMA_BUF_BASE, 0, struct dma_buf_sync)
#define DMA_BUF_SET_NAME	_IOW(DMA_BUF_BASE, 1, const char *)
#define DMA_BUF_SET_NAME_A	_IOW(DMA_BUF_BASE, 1, __u32)
#define DMA_BUF_SET_NAME_B	_IOW(DMA_BUF_BASE, 1, __u64)
#define DMA_BUF_IOCTL_EXPORT_SYNC_FILE	_IOWR(DMA_BUF_BASE, 2, struct dma_buf_export_sync_file)
#define DMA_BUF_IOCTL_IMPORT_SYNC_FILE	_IOW(DMA_BUF_BASE, 3, struct dma_buf_import_sync_file)
```

These macros are provided by `<linux/ioctl.h>`, which is not currently included.

**Placement:** The new include is added before the existing `#include <linux/types.h>`, maintaining alphabetical order. Good.

```c
+#include <linux/ioctl.h>
 #include <linux/types.h>
```

**Commit message:** Clear and concise. Accurately describes the problem and the fix.

**Risk:** Essentially zero. Adding a missing include to a UAPI header cannot break existing users (they must have been including `<linux/ioctl.h>` themselves, either directly or transitively). It only fixes the case where they weren't.

**Reviewed-by worthy:** Yes. No concerns.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-03  2:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03  0:23 [PATCH v1] dma-buf: Include ioctl.h in UAPI header Isaac J. Manjarres
2026-03-03  1:45 ` T.J. Mercier
2026-03-03  2:44 ` Claude review: " Claude Code Review Bot
2026-03-03  2:44 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260303002309.1401849-1-isaacmanjarres@google.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox