From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/doc: Update documentation for 'none' recovery method
Date: Wed, 04 Mar 2026 07:31:27 +1000 [thread overview]
Message-ID: <review-patch1-20260303110556.3577612-2-raag.jadav@intel.com> (raw)
In-Reply-To: <20260303110556.3577612-2-raag.jadav@intel.com>
Patch Review
The documentation change removes the key phrase "was recovered from driver context using device specific methods like reset" and replaces it with a more vague description. However, the new text still says:
```
The only exception to this is ``WEDGED=none``, which signifies that the device
was temporarily 'wedged' at some point but no explicit recovery is expected
```
**Issue: "temporarily" is now inaccurate for the new use case.** In `XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET`, the device is *permanently* wedged - IOCTLs are blocked and `xe->needs_flr_on_fini` is set. The device stays wedged until a rebind. Saying it was "temporarily" wedged is misleading for this scenario.
**Suggestion:** The documentation should explicitly describe both scenarios for `WEDGED=none`: (1) driver already recovered the device via reset, and (2) device is wedged for debug purposes with no recovery intended. This would make the UAPI contract clear rather than muddying the existing semantics.
Minor: "for debug purpose" should be "for debug purposes" (plural).
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-03 21:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 11:05 [PATCH v1 0/3] Update 'none' recovery method for DRM wedged event Raag Jadav
2026-03-03 11:05 ` [PATCH v1 1/3] drm/doc: Update documentation for 'none' recovery method Raag Jadav
2026-03-03 15:32 ` Rodrigo Vivi
2026-03-03 21:31 ` Claude Code Review Bot [this message]
2026-03-03 11:05 ` [PATCH v1 2/3] drm: Update log " Raag Jadav
2026-03-03 15:33 ` Rodrigo Vivi
2026-03-03 21:31 ` Claude review: " Claude Code Review Bot
2026-03-03 11:05 ` [PATCH v1 3/3] drm/xe: Send 'none' recovery method for XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET Raag Jadav
2026-03-03 15:34 ` Rodrigo Vivi
2026-03-03 21:31 ` Claude review: " Claude Code Review Bot
2026-03-03 21:31 ` Claude review: Update 'none' recovery method for DRM wedged event Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260303110556.3577612-2-raag.jadav@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox