From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/doc: Update documentation for 'none' recovery method Date: Wed, 04 Mar 2026 07:31:27 +1000 Message-ID: In-Reply-To: <20260303110556.3577612-2-raag.jadav@intel.com> References: <20260303110556.3577612-1-raag.jadav@intel.com> <20260303110556.3577612-2-raag.jadav@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The documentation change removes the key phrase "was recovered from driver context using device specific methods like reset" and replaces it with a more vague description. However, the new text still says: ``` The only exception to this is ``WEDGED=none``, which signifies that the device was temporarily 'wedged' at some point but no explicit recovery is expected ``` **Issue: "temporarily" is now inaccurate for the new use case.** In `XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET`, the device is *permanently* wedged - IOCTLs are blocked and `xe->needs_flr_on_fini` is set. The device stays wedged until a rebind. Saying it was "temporarily" wedged is misleading for this scenario. **Suggestion:** The documentation should explicitly describe both scenarios for `WEDGED=none`: (1) driver already recovered the device via reset, and (2) device is wedged for debug purposes with no recovery intended. This would make the UAPI contract clear rather than muddying the existing semantics. Minor: "for debug purpose" should be "for debug purposes" (plural). --- Generated by Claude Code Patch Reviewer