From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: panel: Add Himax HX83121A
Date: Wed, 04 Mar 2026 07:28:32 +1000
Message-ID: <review-patch1-20260303115730.9580-2-mitltlatltl@gmail.com>
In-Reply-To: <20260303115730.9580-2-mitltlatltl@gmail.com>
References: <20260303115730.9580-1-mitltlatltl@gmail.com> <20260303115730.9580-2-mitltlatltl@gmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

The binding looks mostly well-structured but has several issues:

**Missing `allOf` reference to `panel-common.yaml`:**

The binding uses `backlight: true` and `unevaluatedProperties: false`, whic=
h implies it should reference the common panel schema. Other himax panel bi=
ndings (e.g., `himax,hx83102.yaml`) include:
```yaml
allOf:
  - $ref: panel-common.yaml#
```
Without this, the `ports` property used in the example would fail validatio=
n against `unevaluatedProperties: false`, since `ports` is not defined in t=
his schema =E2=80=94 it comes from `panel-common.yaml`.

**Missing `port` / `ports` property:**

The example uses a `ports` node with two ports (for dual-DSI), but the sche=
ma doesn't declare a `ports` property. This should be added, or inherited v=
ia `panel-common.yaml`.

**Missing space in example:**

```yaml
+                port@1{
```
Should be `port@1 {` (space before brace) per DT style convention.

**`avdd-supply` and `avee-supply` naming:**

The binding defines:
```yaml
+  avdd-supply:
+    description: analog positive supply for IC
+
+  avee-supply:
+    description: analog negative supply for IC
```
But the driver code uses `vsp` and `vsn` as supply names:
```c
static const struct regulator_bulk_data himax_supplies[] =3D {
	{ .supply =3D "vddi" },
	{ .supply =3D "vsp" },
	{ .supply =3D "vsn" },
};
```
The regulator framework maps the code's supply name + `-supply` suffix to t=
he DT property. So the driver would look for `vsp-supply` and `vsn-supply` =
in DT, **not** `avdd-supply` and `avee-supply`. These must be consistent. E=
ither rename the binding properties to `vsp-supply`/`vsn-supply` or change =
the driver code to use `avdd`/`avee`.

**`avdd-supply` and `avee-supply` should probably be required:**

If the panel needs these supplies to function, they should be listed in `re=
quired:`. Currently only `vddi-supply` and `reset-gpios` are required.

---

---
Generated by Claude Code Patch Reviewer