From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: ARM: dts: twl6032: Add DTS file for TWL6032 PMIC Date: Wed, 04 Mar 2026 06:45:49 +1000 Message-ID: In-Reply-To: <20260303203017.511-2-bavishimithil@gmail.com> References: <20260303203017.511-1-bavishimithil@gmail.com> <20260303203017.511-2-bavishimithil@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This looks reasonable. The TWL6032 dtsi mirrors the structure of the existing `twl6030.dtsi` and defines the appropriate regulator, GPADC, USB, PWM, and RTC nodes. **Minor:** The SPDX license is `GPL-2.0-only` while the board files use `(GPL-2.0 OR MIT)`. This is fine but worth noting the difference is intentional (the PMIC dtsi is strictly GPL like the twl6030.dtsi). **Nit:** The twl6030.dtsi has the `gpadc` node without a label. This file adds `gpadc: gpadc` with a label, which is needed for the `io-channels = <&gpadc 4>` reference in the common dtsi. Fine, but it means other boards including twl6032.dtsi can also use the label, which is a reasonable addition. No blocking issues. --- Generated by Claude Code Patch Reviewer