From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdgpu/amdgpu_connectors: use struct drm_edid instead of struct edid Date: Wed, 04 Mar 2026 08:35:54 +1000 Message-ID: In-Reply-To: <20260303211823.76631-2-jpeisach@ubuntu.com> References: <20260303211823.76631-1-jpeisach@ubuntu.com> <20260303211823.76631-2-jpeisach@ubuntu.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This patch is largely correct. The API migrations are: - `struct edid *edid` =E2=86=92 `const struct drm_edid *edid` in `amdgpu_co= nnector` =E2=80=94 **correct** - `drm_get_edid()` =E2=86=92 `drm_edid_read_ddc()` =E2=80=94 **correct** - `drm_edid_duplicate(drm_edid_raw(...))` =E2=86=92 `drm_edid_dup()` =E2=80= =94 **correct**, cleaner - `drm_connector_update_edid_property()` =E2=86=92 `drm_edid_connector_upda= te()` =E2=80=94 **correct** - `drm_add_edid_modes()` =E2=86=92 `drm_edid_connector_add_modes()` =E2=80= =94 **correct** - `!!(edid->input & DRM_EDID_INPUT_DIGITAL)` =E2=86=92 `drm_edid_is_digital= ()` =E2=80=94 **correct** - `drm_edid_to_speaker_allocation(edid, ...)` =E2=86=92 `drm_edid_to_speake= r_allocation(drm_edid_raw(edid), ...)` =E2=80=94 **correct**, these functio= ns still require `struct edid *` - `drm_edid_to_sad(edid, ...)` =E2=86=92 `drm_edid_to_sad(drm_edid_raw(edid= ), ...)` =E2=80=94 **correct** One minor observation: the `drm_edid_to_sad()` and `drm_edid_to_speaker_all= ocation()` calls in dce_v6_0.c, dce_v8_0.c, and dce_v10_0.c still require t= he raw `struct edid *`, so wrapping with `drm_edid_raw()` is the right appr= oach. Ideally these would eventually get their own `struct drm_edid` versio= ns, but that's out of scope for this series. **Verdict: Patch 1 looks correct.** --- --- Generated by Claude Code Patch Reviewer