From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tegra: tegra_drm.h: fix all uapi kernel-doc warnings
Date: Thu, 05 Mar 2026 13:56:55 +1000
Message-ID: <review-patch1-20260304014152.482104-1-rdunlap@infradead.org>
In-Reply-To: <20260304014152.482104-1-rdunlap@infradead.org>
References: <20260304014152.482104-1-rdunlap@infradead.org> <20260304014152.482104-1-rdunlap@infradead.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Struct member fixes (correct):**

The additions at lines 108 and 116 of the patch are appropriate:

```c
+	/** @cmdbuf: cmd information */
	struct {
```

```c
+	/** @target: relocate target information */
	struct {
```

These correctly add the missing top-level member descriptions for the anony=
mous struct members `cmdbuf` and `target` within `struct drm_tegra_reloc`, =
resolving the first two warnings.

**#define macro doc-comments (incorrect syntax):**

The kernel-doc comments added for the `#define` constants use incorrect syn=
tax. For example:

```c
/**
+ * define DRM_TEGRA_SUBMIT_RELOC_SECTOR_LAYOUT - \
+ *    Select sector layout swizzling for in-memory buffers.
+ *
  * Specify that bit 39 of the patched-in address should be set to switch
```

The correct kernel-doc syntax for a `#define` requires a leading `DOC:` tag=
 or more typically for constants, simply converting `/**` to `/*` to suppre=
ss the warning. If the intent is to make these proper kernel-doc comments, =
the syntax should be:

```c
/**
 * DOC: DRM_TEGRA_SUBMIT_RELOC_SECTOR_LAYOUT
 *
 * Select sector layout swizzling ...
```

The `define MACRO_NAME - description` format used in this patch is not vali=
d kernel-doc syntax. The kernel-doc script recognizes `@define` for macro-l=
ike entities but the format here (`define NAME - \`) doesn't match any reco=
gnized kernel-doc pattern. This will likely either still produce warnings o=
r produce malformed documentation output.

The same issue applies to all three `DRM_TEGRA_SUBMIT_CMD_*` defines.

**Alternative fix:** If the goal is simply to silence the warnings (since t=
hese are simple constants, not function-like macros), the simplest approach=
 is to change `/**` to `/*`, which avoids triggering the kernel-doc parser =
entirely while preserving the descriptive comments. This was effectively wh=
at v1 of Mikko's feedback was about =E2=80=94 but if proper kernel-doc is d=
esired, the `DOC:` form or the correct macro documentation syntax should be=
 used.

**Minor nit:** The member description `cmd information` for `@cmdbuf` is qu=
ite vague. Something like `command buffer relocation info` would be more de=
scriptive, though this is stylistic.

---
Generated by Claude Code Patch Reviewer