public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ras: Introduce the DRM RAS infrastructure over generic netlink
Date: Thu, 05 Mar 2026 13:47:40 +1000	[thread overview]
Message-ID: <review-patch1-20260304074412.464435-8-riana.tauro@intel.com> (raw)
In-Reply-To: <20260304074412.464435-8-riana.tauro@intel.com>

Patch Review

**Bug: Memory leak in `doit_reply_value()`**

```c
ret = get_node_error_counter(node_id, error_id,
                             &error_name, &value);
if (ret)
    return ret;
```

At `drm_ras.c` (in the diff around line 930-934), when `get_node_error_counter()` fails, `msg` has already been allocated via `genlmsg_new()` but is never freed. This should be:
```c
if (ret) {
    nlmsg_free(msg);
    return ret;
}
```

**Bug: Uninitialized `ret` in `drm_ras_nl_list_nodes_dumpit()`**

```c
int ret;
xa_for_each_start(&drm_ras_xa, id, node, ctx->restart) {
    ...
}
if (ret == -EMSGSIZE)
    ctx->restart = id;
return ret;
```

If the xarray is empty, the loop body never executes and `ret` is returned uninitialized. Should be `int ret = 0;`. Same issue exists in `drm_ras_nl_get_error_counter_dumpit()`.

**Concern: No locking on xarray access**

`drm_ras_xa` is accessed from netlink handlers (which can run concurrently) and from driver register/unregister paths. `xa_for_each_start` and `xa_load` are used without RCU or other synchronization. While xarray itself has some internal locking for modifications, the *node pointer* returned by `xa_load()` could become stale if a concurrent unregister frees it. Consider using `rcu_read_lock()` / `xa_for_each` under RCU, or document the expected serialization.

**Concern: `netnsok = true` in genl family**

```c
struct genl_family drm_ras_nl_family __ro_after_init = {
    ...
    .netnsok    = true,
```

This allows the family to be used from non-init network namespaces. Is this intentional for a hardware RAS interface? Typically hardware error reporting should be restricted to the init namespace. Setting `netnsok = false` would be safer.

**Minor: YAML `error-value` is `u32`**

```yaml
      -
        name: error-value
        type: u32
        doc: Current value of the requested error counter.
```

For counters that can accumulate rapidly (especially with `hweight32` adding multiple bits per interrupt), u32 can overflow. Consider whether u64 would be more appropriate for an error counter that may be queried infrequently. This is a uAPI decision that will be hard to change later.

**Minor: `EXPORT_SYMBOL` vs `EXPORT_SYMBOL_GPL`**

```c
EXPORT_SYMBOL(drm_ras_node_register);
EXPORT_SYMBOL(drm_ras_node_unregister);
```

DRM typically uses `EXPORT_SYMBOL_GPL`. These should probably match the convention.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-05  3:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04  7:44 [PATCH v10 0/5] Introduce DRM_RAS using generic netlink for RAS Riana Tauro
2026-03-04  7:44 ` [PATCH v10 1/5] drm/ras: Introduce the DRM RAS infrastructure over generic netlink Riana Tauro
2026-03-05  3:47   ` Claude Code Review Bot [this message]
2026-03-04  7:44 ` [PATCH v10 2/5] drm/xe/xe_drm_ras: Add support for XE DRM RAS Riana Tauro
2026-03-05  3:47   ` Claude review: " Claude Code Review Bot
2026-03-04  7:44 ` [PATCH v10 3/5] drm/xe/xe_hw_error: Integrate DRM RAS with hardware error handling Riana Tauro
2026-03-05  3:47   ` Claude review: " Claude Code Review Bot
2026-03-04  7:44 ` [PATCH v10 4/5] drm/xe/xe_hw_error: Add support for Core-Compute errors Riana Tauro
2026-03-05  3:47   ` Claude review: " Claude Code Review Bot
2026-03-04  7:44 ` [PATCH v10 5/5] drm/xe/xe_hw_error: Add support for PVC SoC errors Riana Tauro
2026-03-05  3:47   ` Claude review: " Claude Code Review Bot
2026-03-05  3:47 ` Claude review: Introduce DRM_RAS using generic netlink for RAS Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-02-28  8:08 [PATCH v9 0/5] " Riana Tauro
2026-02-28  8:08 ` [PATCH v9 1/5] drm/ras: Introduce the DRM RAS infrastructure over generic netlink Riana Tauro
2026-03-03  4:32   ` Claude review: " Claude Code Review Bot
2026-02-23  6:05 [PATCH v8 0/5] Introduce DRM_RAS using generic netlink for RAS Riana Tauro
2026-02-23  6:05 ` [PATCH v8 1/5] drm/ras: Introduce the DRM RAS infrastructure over generic netlink Riana Tauro
2026-02-24  0:45   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260304074412.464435-8-riana.tauro@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox