public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: bridge: anx7625: enforce CONFIG_USB_ROLE_SWITCH dependency
Date: Thu, 05 Mar 2026 13:44:42 +1000	[thread overview]
Message-ID: <review-patch1-20260304083604.724519-1-arnd@kernel.org> (raw)
In-Reply-To: <20260304083604.724519-1-arnd@kernel.org>

Patch Review

**Kconfig change** (`drivers/gpu/drm/bridge/analogix/Kconfig`):

The change from:
```
depends on TYPEC || !TYPEC
```
to:
```
depends on TYPEC
depends on USB_ROLE_SWITCH
```

is correct. The old `TYPEC || !TYPEC` idiom meant "allow building regardless of TYPEC state but ensure we can't be built-in when TYPEC=m" — effectively making it optional. Changing to a hard `depends on` for both TYPEC and USB_ROLE_SWITCH eliminates all nine problematic tristate combinations and ensures the driver can only be built when both subsystems are available at the right level (built-in or module).

**C code change** (`drivers/gpu/drm/bridge/analogix/anx7625.c`):

Removing the `#if IS_REACHABLE(CONFIG_TYPEC)` / `#else` block with the three empty stub functions (`anx7625_typec_set_status`, `anx7625_typec_register`, `anx7625_typec_unregister`) is the correct cleanup. Since TYPEC is now a hard dependency, these stubs can never be reached. The real implementations remain intact and are now unconditionally compiled.

I verified that after the patch, no `IS_REACHABLE` guards or `#if`/`#else` blocks related to TYPEC remain in the file.

**Minor observation**: The commit message mentions the `Fixes:` tag pointing to `f81455b2d332` which introduced the Type-C support — this is appropriate since that commit introduced the USB_ROLE_SWITCH usage without the corresponding Kconfig dependency.

**No issues found.**

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-05  3:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04  8:35 [PATCH] drm: bridge: anx7625: enforce CONFIG_USB_ROLE_SWITCH dependency Arnd Bergmann
2026-03-05  3:44 ` Claude Code Review Bot [this message]
2026-03-05  3:44 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260304083604.724519-1-arnd@kernel.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox