From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/i915/fbdev: fix link failure without FBDEV emulation
Date: Thu, 05 Mar 2026 13:43:29 +1000
Message-ID: <review-patch1-20260304083701.724908-1-arnd@kernel.org>
In-Reply-To: <20260304083701.724908-1-arnd@kernel.org>
References: <20260304083701.724908-1-arnd@kernel.org> <20260304083701.724908-1-arnd@kernel.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Correctness:** The fix is correct. The condition now reads:

```c
if (IS_ENABLED(CONFIG_DRM_FBDEV_EMULATION) &&
    IS_ENABLED(CONFIG_FRAMEBUFFER_CONSOLE) &&
    mem == i915->mm.stolen_region &&
    !intel_fbdev_fb_prefer_stolen(&i915->drm, size)) {
```

Since C short-circuit evaluation will skip `intel_fbdev_fb_prefer_stolen()` when `CONFIG_DRM_FBDEV_EMULATION` is disabled, and the compiler will eliminate the dead code (including the reference to the undefined symbol), this resolves the link error.

**Minor nit:** The commit message has a typo: "contition" should be "condition". This is cosmetic and doesn't affect the fix itself.

**Fixes tag:** Correctly references the commit that introduced the regression (94c7d2861292).

**Scope:** Minimal one-line change (adding one check), appropriately scoped for a build fix.

**No other concerns.** The patch is straightforward and correct.

---
Generated by Claude Code Patch Reviewer