public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display/msm: move DSI PHY bindings to phy/ subdir
Date: Thu, 05 Mar 2026 13:15:25 +1000	[thread overview]
Message-ID: <review-patch1-20260305-msm-dsi-phy-v1-1-0a99ac665995@oss.qualcomm.com> (raw)
In-Reply-To: <20260305-msm-dsi-phy-v1-1-0a99ac665995@oss.qualcomm.com>

Patch Review

**Changes reviewed:**
- 6 YAML files renamed from `display/msm/dsi-phy-*.yaml` to `phy/qcom,dsi-phy-*.yaml`
- `$id` updated in all 6 files to match new paths
- `$ref: dsi-phy-common.yaml#` updated to `$ref: qcom,dsi-phy-common.yaml#` in all 5 PHY variant files

**Positive observations:**
- The `qcom,` vendor prefix is correctly added to the filenames, following DT binding naming conventions
- All internal `$ref` cross-references are updated consistently
- The commit message clearly explains the rationale and references the precedent (HDMI, eDP PHYs)
- The merge strategy note is helpful for maintainers to avoid conflicts

**Minor observation — MAINTAINERS coverage:**

The `DRM DRIVER for Qualcomm display hardware` section in MAINTAINERS has:
```
F:	Documentation/devicetree/bindings/display/msm/
```
which previously covered these files. After this move, `get_maintainer.pl` will no longer associate these bindings with the MSM DRM maintainers (Rob Clark, Dmitry Baryshkov, etc.). They will only be covered by the generic PHY framework wildcard:
```
F:	Documentation/devicetree/bindings/phy/
```
which has different maintainers (Vinod Koul, Neil Armstrong).

This may be intentional (the patch Cc's `linux-phy@lists.infradead.org` and Vinod Koul), but it's worth confirming that the MSM DRM maintainers are okay losing `get_maintainer.pl` coverage for these bindings. If they want to retain coverage, an explicit `F:` line like `F: Documentation/devicetree/bindings/phy/qcom,dsi-phy-*` should be added to the Qualcomm display hardware MAINTAINERS section.

**No correctness issues found.** The patch is clean and ready to merge.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-05  3:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04 23:47 [PATCH] dt-bindings: display/msm: move DSI PHY bindings to phy/ subdir Dmitry Baryshkov
2026-03-05  3:15 ` Claude review: " Claude Code Review Bot
2026-03-05  3:15 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260305-msm-dsi-phy-v1-1-0a99ac665995@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox