From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display/msm: move DSI PHY bindings to phy/ subdir Date: Thu, 05 Mar 2026 13:15:25 +1000 Message-ID: In-Reply-To: <20260305-msm-dsi-phy-v1-1-0a99ac665995@oss.qualcomm.com> References: <20260305-msm-dsi-phy-v1-1-0a99ac665995@oss.qualcomm.com> <20260305-msm-dsi-phy-v1-1-0a99ac665995@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Changes reviewed:** - 6 YAML files renamed from `display/msm/dsi-phy-*.yaml` to `phy/qcom,dsi-p= hy-*.yaml` - `$id` updated in all 6 files to match new paths - `$ref: dsi-phy-common.yaml#` updated to `$ref: qcom,dsi-phy-common.yaml#`= in all 5 PHY variant files **Positive observations:** - The `qcom,` vendor prefix is correctly added to the filenames, following = DT binding naming conventions - All internal `$ref` cross-references are updated consistently - The commit message clearly explains the rationale and references the prec= edent (HDMI, eDP PHYs) - The merge strategy note is helpful for maintainers to avoid conflicts **Minor observation =E2=80=94 MAINTAINERS coverage:** The `DRM DRIVER for Qualcomm display hardware` section in MAINTAINERS has: ``` F: Documentation/devicetree/bindings/display/msm/ ``` which previously covered these files. After this move, `get_maintainer.pl` = will no longer associate these bindings with the MSM DRM maintainers (Rob C= lark, Dmitry Baryshkov, etc.). They will only be covered by the generic PHY= framework wildcard: ``` F: Documentation/devicetree/bindings/phy/ ``` which has different maintainers (Vinod Koul, Neil Armstrong). This may be intentional (the patch Cc's `linux-phy@lists.infradead.org` and= Vinod Koul), but it's worth confirming that the MSM DRM maintainers are ok= ay losing `get_maintainer.pl` coverage for these bindings. If they want to = retain coverage, an explicit `F:` line like `F: Documentation/devicetree/bi= ndings/phy/qcom,dsi-phy-*` should be added to the Qualcomm display hardware= MAINTAINERS section. **No correctness issues found.** The patch is clean and ready to merge. --- Generated by Claude Code Patch Reviewer