From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Handle error from drm_sched_entity_init() Date: Mon, 09 Mar 2026 09:20:15 +1000 Message-ID: In-Reply-To: <20260305-v3d-reset-locking-improv-v2-1-fd53c91f7726@igalia.com> References: <20260305-v3d-reset-locking-improv-v2-0-fd53c91f7726@igalia.com> <20260305-v3d-reset-locking-improv-v2-1-fd53c91f7726@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Straightforward bugfix. The error unwinding correctly walks backwards destroying only the already-initialized entities: ```c err_sched: for (i--; i >= 0; i--) drm_sched_entity_destroy(&v3d_priv->sched_entity[i]); kfree(v3d_priv); return ret; ``` Correct and clean. The `Fixes:` tag referencing the original driver commit is appropriate. --- Generated by Claude Code Patch Reviewer