From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: Wrap dcn32_override_min_req_memclk() in DC_FP_{START, END}
Date: Mon, 09 Mar 2026 09:08:53 +1000 [thread overview]
Message-ID: <review-patch1-20260306062805.1464383-2-xry111@xry111.site> (raw)
In-Reply-To: <20260306062805.1464383-2-xry111@xry111.site>
Patch Review
**Correctness: Correct.**
The added guards:
```c
DC_FP_START();
dcn32_override_min_req_memclk(dc, context);
DC_FP_END();
```
are necessary because `dcn32_override_min_req_memclk()` is defined in `dcn32_fpu.c` (confirmed at `dcn32_fpu.c:3600`), which is compiled with `CC_FLAGS_FPU` per `dc/dml/Makefile:28,65`. The sibling function `dcn32_override_min_req_dcfclk()` at line 1792 does **not** need wrapping because it lives in `dcn32_resource_helpers.c` (a non-FPU file), which is correct.
**Observations:**
1. The commit message is clear and well-structured with the `[Why]` format used by the amdgpu display team.
2. The `Fixes:` tag correctly references `ee7be8f3de1c` which introduced the unguarded call.
3. The `Cc: stable@vger.kernel.org` is appropriate for a bug fix that causes real failures on LoongArch hardware.
4. The pattern is consistent with how `dcn32_internal_validate_bw()` is already wrapped at lines 1770-1771 in the same function.
**No issues found.**
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-08 23:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 6:28 [PATCH] drm/amd/display: Wrap dcn32_override_min_req_memclk() in DC_FP_{START, END} Xi Ruoyao
2026-03-08 23:08 ` Claude review: " Claude Code Review Bot
2026-03-08 23:08 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260306062805.1464383-2-xry111@xry111.site \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox