From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/display: Wrap dcn32_override_min_req_memclk() in DC_FP_{START, END} Date: Mon, 09 Mar 2026 09:08:53 +1000 Message-ID: In-Reply-To: <20260306062805.1464383-2-xry111@xry111.site> References: <20260306062805.1464383-2-xry111@xry111.site> <20260306062805.1464383-2-xry111@xry111.site> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Correctness: Correct.** The added guards: ```c DC_FP_START(); dcn32_override_min_req_memclk(dc, context); DC_FP_END(); ``` are necessary because `dcn32_override_min_req_memclk()` is defined in `dcn32_fpu.c` (confirmed at `dcn32_fpu.c:3600`), which is compiled with `CC_FLAGS_FPU` per `dc/dml/Makefile:28,65`. The sibling function `dcn32_override_min_req_dcfclk()` at line 1792 does **not** need wrapping because it lives in `dcn32_resource_helpers.c` (a non-FPU file), which is correct. **Observations:** 1. The commit message is clear and well-structured with the `[Why]` format used by the amdgpu display team. 2. The `Fixes:` tag correctly references `ee7be8f3de1c` which introduced the unguarded call. 3. The `Cc: stable@vger.kernel.org` is appropriate for a bug fix that causes real failures on LoongArch hardware. 4. The pattern is consistent with how `dcn32_internal_validate_bw()` is already wrapped at lines 1770-1771 in the same function. **No issues found.** --- Generated by Claude Code Patch Reviewer