public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/dsi: remove bpc > 8 entries from allow list
Date: Mon, 09 Mar 2026 09:06:15 +1000	[thread overview]
Message-ID: <review-patch1-20260306092518.37849-1-mitltlatltl@gmail.com> (raw)
In-Reply-To: <20260306092518.37849-1-mitltlatltl@gmail.com>

Patch Review

**Commit message issues:**

1. The commit message says "In upstream the msm, for bpc greater than 8 are not supported yet" — this is grammatically awkward and, more importantly, **factually unclear**. The code *does* support 10/12 bpc at the DSC parameter computation level. If there is a specific hardware or integration issue that makes 10/12 bpc broken, the commit message should explain what that issue is (e.g., incorrect packing, register programming, or observed display corruption).

2. The updated comment claims "DSC 1.1/1.2 block" but the code at line 1848 uses `DRM_DSC_1_1_PRE_SCR` exclusively. Mentioning DSC 1.2 is misleading since this code path only handles pre-SCR DSC 1.1 parameters.

```c
+		 * In the upstream msm, only 8 bpc is supported for DSC 1.1/1.2
+		 * block.
```

This should say "DSC 1.1" only, consistent with:
```c
	/* DPU supports only pre-SCR panels */
	ret = drm_dsc_setup_rc_params(dsc, DRM_DSC_1_1_PRE_SCR);
```

**Functional concerns:**

3. The `Fixes:` tag implies this is a bug fix suitable for stable backport, but no actual bug is described. Removing supported functionality is not a "fix" — it's a feature removal. If 10/12 bpc was never validated on hardware but is otherwise correct code, a `Fixes:` tag is inappropriate. A more accurate approach would be to document the limitation without the `Fixes:` tag, or to explain the specific failure mode.

4. The `rc_parameters_pre_scr` table in `drm_dsc_helper.c` has valid entries for bpc=10. The downstream code in `dsi_populate_dsc_params()` — including `drm_dsc_set_const_params()`, `drm_dsc_set_rc_buf_thresh()`, `drm_dsc_setup_rc_params()`, and the `line_buf_depth` calculation — all work correctly with bpc values of 10 and 12. Removing them without evidence of breakage will regress any panels that actually use 10/12 bpc DSC.

**Recommendation:** This patch should **not be applied** in its current form. The author should either:
- Provide evidence of an actual bug caused by 10/12 bpc (display corruption, register misconfiguration, etc.) and describe it in the commit message, or
- Drop the `Fixes:` tag and reframe this as a deliberate scope reduction with justification for why untested-but-correct code should be removed rather than left in place.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-08 23:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-06  9:25 [PATCH] drm/msm/dsi: remove bpc > 8 entries from allow list Pengyu Luo
2026-03-06 18:47 ` Dmitry Baryshkov
2026-03-06 19:56   ` Eugene Lepshy
2026-03-06 20:19   ` Евгений Лепший
2026-03-07  6:37     ` Pengyu Luo
2026-03-08 23:06 ` Claude review: " Claude Code Review Bot
2026-03-08 23:06 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260306092518.37849-1-mitltlatltl@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox