public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: panel: Document the rotation property
Date: Mon, 09 Mar 2026 08:50:41 +1000	[thread overview]
Message-ID: <review-patch1-20260306124808.166776-1-l.scorcia@gmail.com> (raw)
In-Reply-To: <20260306124808.166776-1-l.scorcia@gmail.com>

Patch Review

**Correctness**: The addition of `rotation: true` is correct. Since this binding already does `allOf: - $ref: panel-common.yaml#`, specifying `rotation: true` allows the property and inherits its type/enum constraints from `panel-common.yaml` (which defines it as a `uint32` with `enum: [0, 90, 180, 270]`). This matches the pattern used for `backlight`, `port`, and `reset-gpios` in the same file.

**Formatting issue**: The patch inadvertently removes a blank line between `reset-gpios` and `backlight`:

```diff
   reset-gpios: true
-
   backlight: true
-
+  rotation: true
   port: true
```

The original file has blank lines separating each property entry for readability. The patch removes the blank line between `reset-gpios` and `backlight`, and also removes the blank line between `backlight` and `port` while inserting `rotation` there. The result would be:

```yaml
  reset-gpios: true
  backlight: true
  rotation: true
  port: true
```

This is a cosmetic style inconsistency compared to the rest of the properties block (which uses blank lines between `vdd-supply`, `vccio-supply`, `reset-gpios`, etc.). The `rotation: true` addition is fine, but the blank line removals appear unintentional and should be preserved. The patch should instead be:

```diff
   reset-gpios: true
 
   backlight: true
 
+  rotation: true
+
   port: true
```

**Minor**: It might be worth adding `rotation` to the example DT node to demonstrate its usage, though this is optional.

**Summary**: Functionally correct, solves a real `dtbs_check` regression. Recommend a respin just to preserve the blank-line formatting between property entries.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-08 22:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-06 12:44 [PATCH v2] dt-bindings: display: panel: Document the rotation property Luca Leonardo Scorcia
2026-03-07 15:05 ` Krzysztof Kozlowski
2026-03-08 22:50 ` Claude review: " Claude Code Review Bot
2026-03-08 22:50 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-03-09 18:03 [PATCH v3] " Luca Leonardo Scorcia
2026-03-10  2:03 ` Claude review: " Claude Code Review Bot
2026-03-10  2:03 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260306124808.166776-1-l.scorcia@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox