From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: panel: Document the rotation property
Date: Mon, 09 Mar 2026 08:50:41 +1000
Message-ID: <review-patch1-20260306124808.166776-1-l.scorcia@gmail.com>
In-Reply-To: <20260306124808.166776-1-l.scorcia@gmail.com>
References: <20260306124808.166776-1-l.scorcia@gmail.com> <20260306124808.166776-1-l.scorcia@gmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Correctness**: The addition of `rotation: true` is correct. Since this binding already does `allOf: - $ref: panel-common.yaml#`, specifying `rotation: true` allows the property and inherits its type/enum constraints from `panel-common.yaml` (which defines it as a `uint32` with `enum: [0, 90, 180, 270]`). This matches the pattern used for `backlight`, `port`, and `reset-gpios` in the same file.

**Formatting issue**: The patch inadvertently removes a blank line between `reset-gpios` and `backlight`:

```diff
   reset-gpios: true
-
   backlight: true
-
+  rotation: true
   port: true
```

The original file has blank lines separating each property entry for readability. The patch removes the blank line between `reset-gpios` and `backlight`, and also removes the blank line between `backlight` and `port` while inserting `rotation` there. The result would be:

```yaml
  reset-gpios: true
  backlight: true
  rotation: true
  port: true
```

This is a cosmetic style inconsistency compared to the rest of the properties block (which uses blank lines between `vdd-supply`, `vccio-supply`, `reset-gpios`, etc.). The `rotation: true` addition is fine, but the blank line removals appear unintentional and should be preserved. The patch should instead be:

```diff
   reset-gpios: true
 
   backlight: true
 
+  rotation: true
+
   port: true
```

**Minor**: It might be worth adding `rotation` to the example DT node to demonstrate its usage, though this is optional.

**Summary**: Functionally correct, solves a real `dtbs_check` regression. Recommend a respin just to preserve the blank-line formatting between property entries.

---
Generated by Claude Code Patch Reviewer