Claude review: drm/i915: handle failure from vga_get_uninterruptible()

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Note:** The cover letter subject says "handle failure from vga_get()" but the patch subject says "vga_get_uninterruptible()" — the patch subject is more accurate.

**Changes in `intel_vga_disable()`:**

The `goto skip` pattern is used correctly here. When `vga_get_uninterruptible()` fails, the code skips the `outb()`/`inb()` VGA register accesses and the matching `vga_put()`, but still performs the MMIO write to `VGA_DISP_DISABLE`:

```c
err = vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO);
if (err)
    goto skip;

outb(0x01, VGA_SEQ_I);
sr1 = inb(VGA_SEQ_D);
outb(sr1 | VGA_SR01_SCREEN_OFF, VGA_SEQ_D);
vga_put(pdev, VGA_RSRC_LEGACY_IO);
udelay(300);

skip:
intel_de_write(display, vga_reg, VGA_DISP_DISABLE);
```

This is correct — the `VGA_DISP_DISABLE` write goes through MMIO (not legacy I/O), so it must still happen regardless of VGA arbitration status. The `udelay(300)` is also correctly skipped since it's only needed after the VGA sequencer register write.

**Changes in `intel_vga_reset_io_mem()`:**

The early `return` on error is clean and appropriate here, since the entire function body is about touching VGA legacy I/O registers:

```c
err = vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO);
if (err)
    return;
```

The added comment explaining the rationale is helpful:
```c
 * We ignore this issue if we can't access the VGA registers, because
 * neither can vgacon.
```

**Minor nits (non-blocking):**

- The `err` variable is declared but only used for a single check-and-branch. This is fine and follows kernel convention.
- The comment in `intel_vga_disable()` could start with a capital letter ("If the VGA ports...") per kernel comment style, but this is truly trivial.

**Verdict:** Patch looks correct and ready to apply. The error handling logic is sound, the skip/return patterns are appropriate for each call site, and the comments explain the reasoning well.

---
Generated by Claude Code Patch Reviewer