public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: iopoll: fix function parameter names in read_poll_timeout_atomic()
Date: Mon, 09 Mar 2026 08:11:16 +1000	[thread overview]
Message-ID: <review-patch1-20260306221033.2357305-1-rdunlap@infradead.org> (raw)
In-Reply-To: <20260306221033.2357305-1-rdunlap@infradead.org>

Patch Review

**Purpose:** Fix kernel-doc warnings by renaming macro parameters `sleep_us` → `delay_us` and `sleep_before_read` → `delay_before_read` to match the existing kernel-doc block.

**Analysis:**

The kernel-doc block documents:
```
 * @delay_us: Time to udelay between reads in us ...
 * @delay_before_read: if it is true, delay @delay_us before read.
```

But the old macro definition used:
```c
#define read_poll_timeout_atomic(op, val, cond, sleep_us, timeout_us, \
				 sleep_before_read, args...) \
	poll_timeout_us_atomic((val) = op(args), cond, sleep_us, timeout_us, sleep_before_read)
```

The fix renames the parameters consistently:
```c
#define read_poll_timeout_atomic(op, val, cond, delay_us, timeout_us, \
				 delay_before_read, args...) \
	poll_timeout_us_atomic((val) = op(args), cond, delay_us, timeout_us, delay_before_read)
```

This is a pure rename of macro parameter names—since these are positional macro parameters, callers are completely unaffected. The name change is also semantically correct: this is the `_atomic` variant that uses `udelay()` (busy-wait delay), not `usleep_range()` (sleeping), so "delay" is the appropriate term. The non-atomic `read_poll_timeout()` correctly retains `sleep_us`/`sleep_before_read` at line 143-145.

The additional fix on the comment line changing `delay_us` to `@delay_us` (adding the kernel-doc parameter reference marker) is a nice minor improvement.

The `Fixes:` tag correctly references the commit that introduced the mismatch.

**Reviewed-by: No issues found.** This is a clean, minimal documentation/naming fix.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-08 22:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-06 22:10 [PATCH v2] iopoll: fix function parameter names in read_poll_timeout_atomic() Randy Dunlap
2026-03-08 22:11 ` Claude Code Review Bot [this message]
2026-03-08 22:11 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260306221033.2357305-1-rdunlap@infradead.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox