From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: iopoll: fix function parameter names in read_poll_timeout_atomic()
Date: Mon, 09 Mar 2026 08:11:16 +1000
Message-ID: <review-patch1-20260306221033.2357305-1-rdunlap@infradead.org>
In-Reply-To: <20260306221033.2357305-1-rdunlap@infradead.org>
References: <20260306221033.2357305-1-rdunlap@infradead.org> <20260306221033.2357305-1-rdunlap@infradead.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Purpose:** Fix kernel-doc warnings by renaming macro parameters `sleep_us=
` =E2=86=92 `delay_us` and `sleep_before_read` =E2=86=92 `delay_before_read=
` to match the existing kernel-doc block.

**Analysis:**

The kernel-doc block documents:
```
 * @delay_us: Time to udelay between reads in us ...
 * @delay_before_read: if it is true, delay @delay_us before read.
```

But the old macro definition used:
```c
#define read_poll_timeout_atomic(op, val, cond, sleep_us, timeout_us, \
				 sleep_before_read, args...) \
	poll_timeout_us_atomic((val) =3D op(args), cond, sleep_us, timeout_us, sle=
ep_before_read)
```

The fix renames the parameters consistently:
```c
#define read_poll_timeout_atomic(op, val, cond, delay_us, timeout_us, \
				 delay_before_read, args...) \
	poll_timeout_us_atomic((val) =3D op(args), cond, delay_us, timeout_us, del=
ay_before_read)
```

This is a pure rename of macro parameter names=E2=80=94since these are posi=
tional macro parameters, callers are completely unaffected. The name change=
 is also semantically correct: this is the `_atomic` variant that uses `ude=
lay()` (busy-wait delay), not `usleep_range()` (sleeping), so "delay" is th=
e appropriate term. The non-atomic `read_poll_timeout()` correctly retains =
`sleep_us`/`sleep_before_read` at line 143-145.

The additional fix on the comment line changing `delay_us` to `@delay_us` (=
adding the kernel-doc parameter reference marker) is a nice minor improveme=
nt.

The `Fixes:` tag correctly references the commit that introduced the mismat=
ch.

**Reviewed-by: No issues found.** This is a clean, minimal documentation/na=
ming fix.

---
Generated by Claude Code Patch Reviewer