From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add documentation for Sahara protocol. Date: Mon, 09 Mar 2026 08:09:00 +1000 Message-ID: In-Reply-To: <20260307-sahara_protocol_new_v2-v2-1-29dc748b5e9c@oss.qualcomm.com> References: <20260307-sahara_protocol_new_v2-v2-0-29dc748b5e9c@oss.qualcomm.com> <20260307-sahara_protocol_new_v2-v2-1-29dc748b5e9c@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This adds 1241 lines of protocol specification documentation under a new `Documentation/sahara/` directory. - **Top-level directory is unusual.** Kernel documentation for bus-specific drivers typically goes under an existing subsection. A new top-level `Documentation/sahara/` for one protocol seems out of place. Consider `Documentation/bus/mhi/sahara_protocol.rst` or similar. - **Not wired into the doc tree.** There's no change to `Documentation/index.rst` or any parent toctree, so `make htmldocs` won't find these files. The index.rst is created but never referenced from the main doc tree. - **The doc is very long (1241 lines) and reads more like an internal protocol spec** than kernel documentation. Consider whether this level of detail is appropriate for the kernel tree, or whether a high-level overview with a reference to the spec would be better. --- Generated by Claude Code Patch Reviewer