From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: vgaarb: pass vga_get_uninterruptible() errors to userspace
Date: Mon, 09 Mar 2026 08:05:36 +1000 [thread overview]
Message-ID: <review-patch1-20260307173538.763188-2-Simon.Richter@hogyros.de> (raw)
In-Reply-To: <20260307173538.763188-2-Simon.Richter@hogyros.de>
Patch Review
**Verdict: Looks good.**
This patch correctly checks the return value of `vga_get_uninterruptible()` in the `vga_arb_write()` "lock" command handler and returns the error to userspace instead of silently proceeding. The error path via `goto done` is the right existing pattern.
Minor style nit: the new `int err;` declaration is placed before the existing `int ret_val;` with a blank line separating them at lines 1146-1147. Kernel style generally groups declarations together without blank lines in between, so `err` could simply be on the same line or adjacent to `ret_val`. Very minor.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-08 22:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 17:35 [PATCH v3 0/5] Bridges without VGA support Simon Richter
2026-03-07 17:35 ` [PATCH v3 1/5] vgaarb: pass vga_get_uninterruptible() errors to userspace Simon Richter
2026-03-08 22:05 ` Claude Code Review Bot [this message]
2026-03-07 17:35 ` [PATCH v3 2/5] vgaarb: pass errors from pci_set_vga_state() up Simon Richter
2026-03-08 22:05 ` Claude review: " Claude Code Review Bot
2026-03-07 17:35 ` [PATCH v3 3/5] vgaarb: mark vga_get() and wrappers as __must_check Simon Richter
2026-03-08 22:05 ` Claude review: " Claude Code Review Bot
2026-03-07 17:35 ` [PATCH v3 4/5] pci: check if VGA decoding was really activated Simon Richter
2026-03-08 22:05 ` Claude review: " Claude Code Review Bot
2026-03-07 17:35 ` [PATCH v3 5/5] pci: mark pci_set_vga_state() as __must_check Simon Richter
2026-03-08 22:05 ` Claude review: " Claude Code Review Bot
2026-03-08 22:05 ` Claude review: Bridges without VGA support Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260307173538.763188-2-Simon.Richter@hogyros.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox