From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: vgaarb: pass vga_get_uninterruptible() errors to userspace Date: Mon, 09 Mar 2026 08:05:36 +1000 Message-ID: In-Reply-To: <20260307173538.763188-2-Simon.Richter@hogyros.de> References: <20260307173538.763188-1-Simon.Richter@hogyros.de> <20260307173538.763188-2-Simon.Richter@hogyros.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Verdict: Looks good.** This patch correctly checks the return value of `vga_get_uninterruptible()` in the `vga_arb_write()` "lock" command handler and returns the error to userspace instead of silently proceeding. The error path via `goto done` is the right existing pattern. Minor style nit: the new `int err;` declaration is placed before the existing `int ret_val;` with a blank line separating them at lines 1146-1147. Kernel style generally groups declarations together without blank lines in between, so `err` could simply be on the same line or adjacent to `ret_val`. Very minor. --- Generated by Claude Code Patch Reviewer