public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ras: Fix memory leak in doit_reply_value() error path
Date: Mon, 09 Mar 2026 08:03:42 +1000	[thread overview]
Message-ID: <review-patch1-20260307184541.257941-1-shuicheng.lin@intel.com> (raw)
In-Reply-To: <20260307184541.257941-1-shuicheng.lin@intel.com>

Patch Review

**Bug identification is correct.** The original code at the `get_node_error_counter()` failure path:

```c
ret = get_node_error_counter(node_id, error_id,
                             &error_name, &value);
if (ret)
    return ret;
```

This leaks `msg` (allocated earlier via `genlmsg_new()`) and also fails to call `genlmsg_cancel()` to undo the `genlmsg_iput()`.

**The fix is correct and follows kernel conventions:**

1. The `err_cancel_msg` label properly calls `genlmsg_cancel(msg, hdr)` before falling through to `err_free_msg`, which calls `nlmsg_free(msg)`. This ordering is correct — cancel the genl message header first, then free the underlying skb.

2. The `err_free_msg` label (used when `genlmsg_iput()` fails) correctly only frees the msg without calling `genlmsg_cancel()`, since there's no valid `hdr` to cancel at that point.

3. The `msg_reply_value()` error path, which previously had its own inline `genlmsg_cancel()` + `nlmsg_free()`, now correctly shares the `err_cancel_msg` goto target, eliminating code duplication.

**Minor observation:** The `Fixes:` tag references `c36218dc49f5`, which is appropriate as it targets the commit that introduced the buggy code.

**No issues found.** The patch is clean, minimal, and correct.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-08 22:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-07 18:45 [PATCH] drm/ras: Fix memory leak in doit_reply_value() error path Shuicheng Lin
2026-03-08 22:03 ` Claude review: " Claude Code Review Bot
2026-03-08 22:03 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260307184541.257941-1-shuicheng.lin@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox