public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/loongson: use drm_gem_ttm_dumb_map_offset()
Date: Mon, 09 Mar 2026 07:52:56 +1000	[thread overview]
Message-ID: <review-patch1-20260308-master-v1-1-af32d71c8a1d@gmail.com> (raw)
In-Reply-To: <20260308-master-v1-1-af32d71c8a1d@gmail.com>

Patch Review

**Correctness:** The removed `lsdc_dumb_map_offset()` at `lsdc_gem.c:147-161` is functionally identical to `drm_gem_ttm_dumb_map_offset()` at `drm_gem_ttm_helper.c:137-151` — same object lookup, same `drm_vma_node_offset_addr()` call, same `drm_gem_object_put()`, same return values. This is a safe substitution.

**Changes are complete:**
- `lsdc_drv.c`: Adds `#include <drm/drm_gem_ttm_helper.h>` and swaps `.dumb_map_offset` assignment — correct.
- `lsdc_gem.c`: Removes the function body — correct.
- `lsdc_gem.h`: Removes the declaration — correct.
- No remaining references to `lsdc_dumb_map_offset` exist in the tree after this patch.

**Minor nit:** The removal in `lsdc_gem.c` leaves a double blank line (the original blank before the function plus the blank after the closing brace). This is cosmetically harmless but could be cleaned up to a single blank line. Very minor — not worth blocking.

**Other drivers using the same pattern:** Multiple TTM-based drivers (xe, nouveau, vmwgfx, qxl, hibmc) already use `drm_gem_ttm_dumb_map_offset()`, so this aligns loongson with established convention.

Reviewed-by: looks appropriate here.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-08 21:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-08 10:15 [PATCH] drm/loongson: use drm_gem_ttm_dumb_map_offset() Amin GATTOUT
2026-03-08 21:52 ` Claude Code Review Bot [this message]
2026-03-08 21:52 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260308-master-v1-1-af32d71c8a1d@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox