From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/loongson: use drm_gem_ttm_dumb_map_offset() Date: Mon, 09 Mar 2026 07:52:56 +1000 Message-ID: In-Reply-To: <20260308-master-v1-1-af32d71c8a1d@gmail.com> References: <20260308-master-v1-1-af32d71c8a1d@gmail.com> <20260308-master-v1-1-af32d71c8a1d@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness:** The removed `lsdc_dumb_map_offset()` at `lsdc_gem.c:147-16= 1` is functionally identical to `drm_gem_ttm_dumb_map_offset()` at `drm_gem= _ttm_helper.c:137-151` =E2=80=94 same object lookup, same `drm_vma_node_off= set_addr()` call, same `drm_gem_object_put()`, same return values. This is = a safe substitution. **Changes are complete:** - `lsdc_drv.c`: Adds `#include ` and swaps `.dumb= _map_offset` assignment =E2=80=94 correct. - `lsdc_gem.c`: Removes the function body =E2=80=94 correct. - `lsdc_gem.h`: Removes the declaration =E2=80=94 correct. - No remaining references to `lsdc_dumb_map_offset` exist in the tree after= this patch. **Minor nit:** The removal in `lsdc_gem.c` leaves a double blank line (the = original blank before the function plus the blank after the closing brace).= This is cosmetically harmless but could be cleaned up to a single blank li= ne. Very minor =E2=80=94 not worth blocking. **Other drivers using the same pattern:** Multiple TTM-based drivers (xe, n= ouveau, vmwgfx, qxl, hibmc) already use `drm_gem_ttm_dumb_map_offset()`, so= this aligns loongson with established convention. Reviewed-by: looks appropriate here. --- Generated by Claude Code Patch Reviewer