From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: panel: Add Novatek NT35532 LCD DSI
Date: Mon, 09 Mar 2026 07:46:26 +1000
Message-ID: <review-patch1-20260308-rimob-new-features-v1-1-aa2c330572c0@protonmail.com>
In-Reply-To: <20260308-rimob-new-features-v1-1-aa2c330572c0@protonmail.com>
References: <20260308-rimob-new-features-v1-0-aa2c330572c0@protonmail.com> <20260308-rimob-new-features-v1-1-aa2c330572c0@protonmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

The binding uses a bare controller IC compatible:

```yaml
compatible:
    const: novatek,nt35532
```

The NT35532 is a display controller IC, not a specific panel. Following the established convention (e.g., `novatek,nt35510.yaml`), the compatible should include a panel-specific first entry with `novatek,nt35532` as a fallback:

```yaml
compatible:
    items:
      - enum:
          - <panel-vendor>,<panel-model>
      - const: novatek,nt35532
```

The DT bindings maintainers (Rob/Krzysztof/Conor) will very likely request this change. Even if the exact panel vendor/model is unknown, using the board/device name (e.g., `flipkart,rimob-panel`) as the first compatible is the expected practice. This allows future kernel changes if different NT35532-based panels need different init sequences.

The rest of the binding looks fine: `vsn-supply`/`vsp-supply` naming for negative/positive analog supplies, required properties, and the example are all reasonable.

The MAINTAINERS entry is fine, with the driver file path correctly added in patch 2.

---
Generated by Claude Code Patch Reviewer