From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: rust: ptr: add `KnownSize` trait to support DST size info extraction Date: Tue, 10 Mar 2026 12:10:28 +1000 Message-ID: In-Reply-To: <20260309-drm-rust-next-v4-1-4ef485b19a4c@proton.me> References: <20260309-drm-rust-next-v4-0-4ef485b19a4c@proton.me> <20260309-drm-rust-next-v4-1-4ef485b19a4c@proton.me> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean and minimal. The `KnownSize` trait is a well-scoped replacement for the unstable `core::mem::size_of_val_raw`. One minor nit: the `//` comment in the import block at line 467 of the diff: ```rust use core::mem::{ align_of, size_of, // }; ``` The trailing `//` appears to be a formatting workaround (possibly to prevent `rustfmt` from collapsing the import to a single line). This pattern is used elsewhere in the kernel Rust code so it's consistent, but it's slightly unusual. No functional issues. The `slice_ptr_len` feature gate is appropriate for `<*const [T]>::len()`. --- Generated by Claude Code Patch Reviewer