From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH v2 1/2] dt-bindings: display: panel: Document Tianma TA066VVHM03
Date: Tue, 10 Mar 2026 12:50:30 +1000 [thread overview]
Message-ID: <review-patch1-20260309-idealistic-dingo-from-venus-c443af@quoll> (raw)
In-Reply-To: <20260309-idealistic-dingo-from-venus-c443af@quoll>
Patch Review
This patch adds the YAML DT binding for the panel. It has already been reviewed by Krzysztof Kozlowski.
**Minor issue: `enable-gpios` is optional in the binding but mandatory in the driver.**
The binding lists `enable-gpios: true` in properties but does **not** include it in the `required` block. However, in the driver (patch 2), `devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW)` is used without `_optional`, meaning probe will fail if the GPIO is not present. Either:
- Add `enable-gpios` to the `required` list in the binding, or
- Use `devm_gpiod_get_optional()` in the driver.
Since the cover letter says this is for the ASUS ROG Phone 3 specifically and the example DT includes `enable-gpios`, making it required in the binding seems like the right choice.
**Otherwise looks good.** The binding correctly documents the three supplies, reset-gpios, and port as required.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-10 2:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 21:08 [PATCH v2 0/2] Add support for Tianma TA066VVHM03 DSI panel Alexander Koskovich
2026-03-08 21:09 ` [PATCH v2 1/2] dt-bindings: display: panel: Document Tianma TA066VVHM03 Alexander Koskovich
2026-03-09 7:35 ` Krzysztof Kozlowski
2026-03-09 7:41 ` Alexander Koskovich
2026-03-09 7:54 ` Krzysztof Kozlowski
2026-03-09 7:59 ` Alexander Koskovich
2026-03-10 2:50 ` Claude Code Review Bot [this message]
2026-03-08 21:09 ` [PATCH v2 2/2] drm/panel: Add support for Tianma TA066VVHM03 panel Alexander Koskovich
2026-03-10 2:50 ` Claude review: " Claude Code Review Bot
2026-03-10 2:50 ` Claude review: Add support for Tianma TA066VVHM03 DSI panel Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260309-idealistic-dingo-from-venus-c443af@quoll \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox