From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH v2 1/2] dt-bindings: display: panel: Document Tianma TA066VVHM03 Date: Tue, 10 Mar 2026 12:50:30 +1000 Message-ID: In-Reply-To: <20260309-idealistic-dingo-from-venus-c443af@quoll> References: <20260308-tianma-ta066vvhm03-v2-0-5f2344685133@pm.me> <20260309-idealistic-dingo-from-venus-c443af@quoll> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This patch adds the YAML DT binding for the panel. It has already been reviewed by Krzysztof Kozlowski. **Minor issue: `enable-gpios` is optional in the binding but mandatory in the driver.** The binding lists `enable-gpios: true` in properties but does **not** include it in the `required` block. However, in the driver (patch 2), `devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW)` is used without `_optional`, meaning probe will fail if the GPIO is not present. Either: - Add `enable-gpios` to the `required` list in the binding, or - Use `devm_gpiod_get_optional()` in the driver. Since the cover letter says this is for the ASUS ROG Phone 3 specifically and the example DT includes `enable-gpios`, making it required in the binding seems like the right choice. **Otherwise looks good.** The binding correctly documents the three supplies, reset-gpios, and port as required. --- --- Generated by Claude Code Patch Reviewer