From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/ttm: document that ttm_bo_swapout deals with pages Date: Tue, 10 Mar 2026 11:58:56 +1000 Message-ID: In-Reply-To: <20260309-ttm_bo_swapout_doc-v1-1-eeb08176a00b@igalia.com> References: <20260309-ttm_bo_swapout_doc-v1-1-eeb08176a00b@igalia.com> <20260309-ttm_bo_swapout_doc-v1-1-eeb08176a00b@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Correct, ready to merge.** The patch fixes two inaccuracies in the kerneldoc for `ttm_bo_swapout()`: 1. `@target` parameter was documented as "bytes" but is actually "pages" 2. Return value was documented as "bytes" but is actually "pages" This is verifiable by tracing the code: - `ttm_bo_swapout()` passes `target` directly to `ttm_lru_walk_for_evict()` at `ttm_bo.c:1234` - The `process_bo` callback (`ttm_bo_swapout_cb`) returns `num_pages` (from `tt->num_pages`) at `ttm_bo.c:1144` for deleted BOs - `ttm_lru_walk_for_evict()` accumulates these return values as `progress` and compares against `target` at `ttm_bo_util.c:912-913` So `target` and the return value are unambiguously in pages. **Minor pre-existing nit (not introduced by this patch):** The `@man` doc at line 1212 has a typo: "goint" should be "going". The author may want to fix that in a follow-up or fold it in if they respin. --- Generated by Claude Code Patch Reviewer