From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: bridge: Add ITE IT6162 MIPI DSI to HDMI bridge Date: Tue, 10 Mar 2026 12:31:49 +1000 Message-ID: In-Reply-To: <20260309-upstream-6162-v2-1-debdb6c88030@ite.com.tw> References: <20260309-upstream-6162-v2-0-debdb6c88030@ite.com.tw> <20260309-upstream-6162-v2-1-debdb6c88030@ite.com.tw> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Issues:** 1. **Typo in v2 changelog**: The cover letter says `"ite,spport-hdcp"` (lin= e 440) instead of `"ite,support-hdcp"`. Minor but worth fixing for consiste= ncy. 2. **Vendor-specific boolean property naming**: The property `ite,support-h= dcp` is a policy/configuration knob, not a hardware description. DT binding= s should describe hardware capabilities, not software policy. If the hardwa= re has HDCP key storage wired up, a property like `ite,hdcp-supported` woul= d be more appropriate, but even then reviewers may push back =E2=80=94 typi= cally HDCP enablement is handled in userspace through the content_protectio= n connector property. Consider whether this really belongs in DT. 3. **Missing newline at end of file** (line 328: `\ No newline at end of fi= le`). The YAML file should end with a newline. 4. **Port numbering and required ports**: Only `port@1` (DSI-1) is required= , but the driver code iterates ports 0 and 1, and the cover letter says sin= gle DSI uses one port. It seems like `port@1` being the only mandatory port= is unusual =E2=80=94 typically `port@0` would be required for single-DSI c= onfigurations. The comment `# Only DSI-1 port is mandatory per your request= ` (line 253) should be removed or rephrased. 5. **`lane-polarities` redefines existing schema**: The `lane-polarities` p= roperty is already defined in `video-interfaces.yaml`. Redefining its `$ref= ` to `types.yaml#/definitions/uint32-array` with custom constraints may con= flict. Consider just using the standard property without overriding its typ= e. 6. **HDMI output port marked optional**: `port@3` (HDMI output) is describe= d as "optional" but for a DSI-to-HDMI bridge, the HDMI output port should a= rguably be required. --- --- Generated by Claude Code Patch Reviewer