From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: verisilicon: add max cursor size to HWDB
Date: Tue, 10 Mar 2026 12:36:01 +1000 [thread overview]
Message-ID: <review-patch1-20260309085302.3132732-2-zhengxingda@iscas.ac.cn> (raw)
In-Reply-To: <20260309085302.3132732-2-zhengxingda@iscas.ac.cn>
Patch Review
This patch is straightforward and mostly fine.
**Type style issue:** In `vs_hwdb.h`:
```c
int32_t max_cursor_size;
```
Kernel convention for struct members is to use the kernel-native types (`s32` or just `u32` since the value is always positive). All other fields in `struct vs_chip_identity` use `u32`. Since cursor size is always a positive value (32, 64, 128, 256), `u32` would be more consistent and appropriate.
**Missing `cursor_width`/`cursor_height` in mode_config:** The `vs_mode_config_init()` in `vs_drm.c` does not set `drm->mode_config.cursor_width` and `drm->mode_config.cursor_height`. These default to 64x64, which happens to match the current HWDB entries, but if a DC variant supports 128 or 256 this would be wrong. These should be set from `dc->identity.max_cursor_size` so userspace gets the correct max cursor size advertised via `DRM_CAP_CURSOR_WIDTH`/`DRM_CAP_CURSOR_HEIGHT`. This could be done in patch 2 but is worth noting here.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-10 2:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 8:53 [PATCH -next 0/2] drm: verisilicon: add hardware cursor support Icenowy Zheng
2026-03-09 8:53 ` [PATCH -next 1/2] drm: verisilicon: add max cursor size to HWDB Icenowy Zheng
2026-03-10 2:36 ` Claude Code Review Bot [this message]
2026-03-09 8:53 ` [PATCH -next 2/2] drm: verisilicon: add support for cursor planes Icenowy Zheng
2026-03-10 2:36 ` Claude review: " Claude Code Review Bot
2026-03-10 2:36 ` Claude review: drm: verisilicon: add hardware cursor support Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-24 6:02 [PATCH -next v2 0/2] " Icenowy Zheng
2026-03-24 6:02 ` [PATCH -next v2 1/2] drm: verisilicon: add max cursor size to HWDB Icenowy Zheng
2026-03-24 21:03 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260309085302.3132732-2-zhengxingda@iscas.ac.cn \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox