From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: verisilicon: add max cursor size to HWDB Date: Tue, 10 Mar 2026 12:36:01 +1000 Message-ID: In-Reply-To: <20260309085302.3132732-2-zhengxingda@iscas.ac.cn> References: <20260309085302.3132732-1-zhengxingda@iscas.ac.cn> <20260309085302.3132732-2-zhengxingda@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This patch is straightforward and mostly fine. **Type style issue:** In `vs_hwdb.h`: ```c int32_t max_cursor_size; ``` Kernel convention for struct members is to use the kernel-native types (`s32` or just `u32` since the value is always positive). All other fields in `struct vs_chip_identity` use `u32`. Since cursor size is always a positive value (32, 64, 128, 256), `u32` would be more consistent and appropriate. **Missing `cursor_width`/`cursor_height` in mode_config:** The `vs_mode_config_init()` in `vs_drm.c` does not set `drm->mode_config.cursor_width` and `drm->mode_config.cursor_height`. These default to 64x64, which happens to match the current HWDB entries, but if a DC variant supports 128 or 256 this would be wrong. These should be set from `dc->identity.max_cursor_size` so userspace gets the correct max cursor size advertised via `DRM_CAP_CURSOR_WIDTH`/`DRM_CAP_CURSOR_HEIGHT`. This could be done in patch 2 but is worth noting here. --- Generated by Claude Code Patch Reviewer