From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/dsi: add the missing parameter description
Date: Tue, 10 Mar 2026 12:27:21 +1000 [thread overview]
Message-ID: <review-patch1-20260309100254.877801-1-mitltlatltl@gmail.com> (raw)
In-Reply-To: <20260309100254.877801-1-mitltlatltl@gmail.com>
Patch Review
**Result: Incorrect fix — NAK**
The patch adds:
```
+ * @is_bonded_dsi: True if two DSI controllers are bonded
```
to the kernel-doc comment for `dsi_adjust_pclk_for_compression()`, but this function's signature is:
```c
static unsigned long dsi_adjust_pclk_for_compression(
const struct drm_display_mode *mode,
const struct drm_dsc_config *dsc)
```
It has no `is_bonded_dsi` parameter. The author likely confused this function with `dsi_host_get_pclk_rate()` which does use `is_bonded_dsi` (at line 615). The `@is_bonded_dsi` doc entry should be added to whichever function actually has that parameter, not here.
This patch as written would trade one kernel-doc warning for another (excess `@is_bonded_dsi` description with no matching parameter).
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-10 2:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 10:02 [PATCH] drm/msm/dsi: add the missing parameter description Pengyu Luo
2026-03-10 2:27 ` Claude Code Review Bot [this message]
2026-03-10 2:27 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260309100254.877801-1-mitltlatltl@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox