From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dsi: add the missing parameter description Date: Tue, 10 Mar 2026 12:27:21 +1000 Message-ID: In-Reply-To: <20260309100254.877801-1-mitltlatltl@gmail.com> References: <20260309100254.877801-1-mitltlatltl@gmail.com> <20260309100254.877801-1-mitltlatltl@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Result: Incorrect fix =E2=80=94 NAK** The patch adds: ``` + * @is_bonded_dsi: True if two DSI controllers are bonded ``` to the kernel-doc comment for `dsi_adjust_pclk_for_compression()`, but this= function's signature is: ```c static unsigned long dsi_adjust_pclk_for_compression( const struct drm_display_mode *mode, const struct drm_dsc_config *dsc) ``` It has no `is_bonded_dsi` parameter. The author likely confused this functi= on with `dsi_host_get_pclk_rate()` which does use `is_bonded_dsi` (at line = 615). The `@is_bonded_dsi` doc entry should be added to whichever function = actually has that parameter, not here. This patch as written would trade one kernel-doc warning for another (exces= s `@is_bonded_dsi` description with no matching parameter). --- Generated by Claude Code Patch Reviewer