public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: panel: Document the rotation property
Date: Tue, 10 Mar 2026 12:03:47 +1000	[thread overview]
Message-ID: <review-patch1-20260309180353.8220-1-l.scorcia@gmail.com> (raw)
In-Reply-To: <20260309180353.8220-1-l.scorcia@gmail.com>

Patch Review

**Purpose:** The Jadard jd9365da-h3 panel driver already reads the `rotation` property from DT (via `panel-common.yaml` / `of_drm_get_panel_orientation`), but the binding schema didn't list it. This causes `dtbs_check` warnings for boards like the Xiaomi Mi Smart Clock x04g that use the property.

**Review:**

The change is correct. The binding already references `panel-common.yaml` via `allOf`:

```yaml
allOf:
  - $ref: panel-common.yaml#
```

And the file has `additionalProperties: false` (line 49), which means any property not explicitly listed is flagged as an error by `dt-validate`. Adding `rotation: true` delegates the schema validation to the referenced `panel-common.yaml`, which properly constrains rotation values to `{0, 90, 180, 270}`.

**Minor nit:** The patch removes a blank line between `reset-gpios` and `backlight` (lines 121-123 of the diff). This is a cosmetic whitespace change that wasn't mentioned in the commit message. It doesn't matter functionally, but mixing unrelated whitespace changes with the actual fix is slightly untidy. That said, given how trivial this is, it's not worth re-spinning.

**Verdict:** Patch looks good. The commit message clearly explains the what and why, the Acked-by is present, and the change itself is minimal and correct.

Reviewed-by quality: **Accept as-is.**

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-10  2:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09 18:03 [PATCH v3] dt-bindings: display: panel: Document the rotation property Luca Leonardo Scorcia
2026-03-10  2:03 ` Claude Code Review Bot [this message]
2026-03-10  2:03 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-06 12:44 [PATCH v2] " Luca Leonardo Scorcia
2026-03-08 22:50 ` Claude review: " Claude Code Review Bot
2026-03-08 22:50 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260309180353.8220-1-l.scorcia@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox