From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: panel: Document the rotation property Date: Tue, 10 Mar 2026 12:03:47 +1000 Message-ID: In-Reply-To: <20260309180353.8220-1-l.scorcia@gmail.com> References: <20260309180353.8220-1-l.scorcia@gmail.com> <20260309180353.8220-1-l.scorcia@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Purpose:** The Jadard jd9365da-h3 panel driver already reads the `rotation` property from DT (via `panel-common.yaml` / `of_drm_get_panel_orientation`), but the binding schema didn't list it. This causes `dtbs_check` warnings for boards like the Xiaomi Mi Smart Clock x04g that use the property. **Review:** The change is correct. The binding already references `panel-common.yaml` via `allOf`: ```yaml allOf: - $ref: panel-common.yaml# ``` And the file has `additionalProperties: false` (line 49), which means any property not explicitly listed is flagged as an error by `dt-validate`. Adding `rotation: true` delegates the schema validation to the referenced `panel-common.yaml`, which properly constrains rotation values to `{0, 90, 180, 270}`. **Minor nit:** The patch removes a blank line between `reset-gpios` and `backlight` (lines 121-123 of the diff). This is a cosmetic whitespace change that wasn't mentioned in the commit message. It doesn't matter functionally, but mixing unrelated whitespace changes with the actual fix is slightly untidy. That said, given how trivial this is, it's not worth re-spinning. **Verdict:** Patch looks good. The commit message clearly explains the what and why, the Acked-by is present, and the change itself is minimal and correct. Reviewed-by quality: **Accept as-is.** --- Generated by Claude Code Patch Reviewer