public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: gsp: fix stale doc comments on command queue methods
Date: Wed, 11 Mar 2026 13:32:09 +1000	[thread overview]
Message-ID: <review-patch1-20260310-cmdq-locking-v4-1-4e5c4753c408@nvidia.com> (raw)
In-Reply-To: <20260310-cmdq-locking-v4-1-4e5c4753c408@nvidia.com>

Patch Review

Clean documentation-only patch. Updates doc comments on `send_command` and `receive_msg` to match current behavior.

The change from `EAGAIN` to `ERANGE` in the doc comments for non-matching messages aligns with what appears to be an earlier refactoring:

```rust
+    /// - `ERANGE` if the message had a recognized but non-matching function code.
```

And the addition of the `EMSGSIZE` error documentation for `send_command`:
```rust
+    /// - `EMSGSIZE` if the command exceeds the maximum queue element size.
```

This is a good cleanup. Note that the existing tree's `send_command` doc mentions `EAGAIN` for insufficient space (line 487 of the current tree), while this patch's context shows `ETIMEDOUT` -- this implies the prerequisite series already changed the space-waiting behavior to use a polling timeout, which is consistent.

No issues.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-11  3:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-10  8:09 [PATCH v4 0/5] gpu: nova-core: gsp: add locking to Cmdq Eliot Courtney
2026-03-10  8:09 ` [PATCH v4 1/5] gpu: nova-core: gsp: fix stale doc comments on command queue methods Eliot Courtney
2026-03-11  3:32   ` Claude Code Review Bot [this message]
2026-03-10  8:09 ` [PATCH v4 2/5] gpu: nova-core: gsp: add `RECEIVE_TIMEOUT` constant for command queue Eliot Courtney
2026-03-11  3:32   ` Claude review: " Claude Code Review Bot
2026-03-10  8:09 ` [PATCH v4 3/5] gpu: nova-core: gsp: add reply/no-reply info to `CommandToGsp` Eliot Courtney
2026-03-11  3:32   ` Claude review: " Claude Code Review Bot
2026-03-10  8:09 ` [PATCH v4 4/5] gpu: nova-core: gsp: make `Cmdq` a pinned type Eliot Courtney
2026-03-11  3:32   ` Claude review: " Claude Code Review Bot
2026-03-10  8:09 ` [PATCH v4 5/5] gpu: nova-core: gsp: add mutex locking to Cmdq Eliot Courtney
2026-03-11  3:32   ` Claude review: " Claude Code Review Bot
2026-03-11  3:32 ` Claude review: gpu: nova-core: gsp: add " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-04  2:46 [PATCH v3 0/5] " Eliot Courtney
2026-03-04  2:46 ` [PATCH v3 1/5] gpu: nova-core: gsp: fix stale doc comments on command queue methods Eliot Courtney
2026-03-05  3:52   ` Claude review: " Claude Code Review Bot
2026-02-26 14:50 [PATCH v2 0/4] gpu: nova-core: gsp: add locking to Cmdq Eliot Courtney
2026-02-26 14:50 ` [PATCH v2 1/4] gpu: nova-core: gsp: fix stale doc comments on command queue methods Eliot Courtney
2026-02-27  2:04   ` Claude review: " Claude Code Review Bot
2026-02-25 13:41 [PATCH 0/4] gpu: nova-core: gsp: add locking to Cmdq Eliot Courtney
2026-02-25 13:41 ` [PATCH 1/4] gpu: nova-core: gsp: fix stale doc comments on command queue methods Eliot Courtney
2026-02-27  3:18   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260310-cmdq-locking-v4-1-4e5c4753c408@nvidia.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox