From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: fix stale doc comments on command queue methods Date: Wed, 11 Mar 2026 13:32:09 +1000 Message-ID: In-Reply-To: <20260310-cmdq-locking-v4-1-4e5c4753c408@nvidia.com> References: <20260310-cmdq-locking-v4-0-4e5c4753c408@nvidia.com> <20260310-cmdq-locking-v4-1-4e5c4753c408@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean documentation-only patch. Updates doc comments on `send_command` and `receive_msg` to match current behavior. The change from `EAGAIN` to `ERANGE` in the doc comments for non-matching messages aligns with what appears to be an earlier refactoring: ```rust + /// - `ERANGE` if the message had a recognized but non-matching function code. ``` And the addition of the `EMSGSIZE` error documentation for `send_command`: ```rust + /// - `EMSGSIZE` if the command exceeds the maximum queue element size. ``` This is a good cleanup. Note that the existing tree's `send_command` doc mentions `EAGAIN` for insufficient space (line 487 of the current tree), while this patch's context shows `ETIMEDOUT` -- this implies the prerequisite series already changed the space-waiting behavior to use a polling timeout, which is consistent. No issues. --- Generated by Claude Code Patch Reviewer