From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/atomic: Document atomic state lifetime Date: Wed, 11 Mar 2026 13:09:06 +1000 Message-ID: In-Reply-To: <20260310-drm-mode-config-init-v1-1-de7397c8e1cf@kernel.org> References: <20260310-drm-mode-config-init-v1-0-de7397c8e1cf@kernel.org> <20260310-drm-mode-config-init-v1-1-de7397c8e1cf@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Good documentation addition. The explanation of `drm_atomic_state` vs individual object states and their lifecycle is clear and useful. Minor nit: "a pointer to individual objects states" should be "pointers to individual object states" (line ~285 in the doc comment): ``` * that holds a state update as a collection of pointer to individual * objects states. ``` Also "the state we'll eventually have to free when the drm_atomic_state will be destroyed, but points to the new state for now" is a bit confusing on first read - the "existing" state pointer concept could use a bit more clarity. --- Generated by Claude Code Patch Reviewer