From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: inno-hdmi: Switch to drmm_kzalloc() Date: Tue, 10 Mar 2026 11:47:01 +1000 Message-ID: In-Reply-To: <20260310-drm-rk-fixes-v2-1-645ecfb43f49@collabora.com> References: <20260310-drm-rk-fixes-v2-0-645ecfb43f49@collabora.com> <20260310-drm-rk-fixes-v2-1-645ecfb43f49@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Verdict: Good** Straightforward fix. The `hdmi` struct embeds the encoder via `hdmi->encoder.encoder`, and `drmm_encoder_init()` is used to initialize it. Switching from `devm_kzalloc(dev, ...)` to `drmm_kzalloc(drm, ...)` ensures the struct outlives the encoder cleanup. ```c - hdmi = devm_kzalloc(dev, sizeof(*hdmi), GFP_KERNEL); + hdmi = drmm_kzalloc(drm, sizeof(*hdmi), GFP_KERNEL); ``` The `drm` variable is already available as `data` parameter. No issues. --- Generated by Claude Code Patch Reviewer