From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add documentation for Sahara protocol. Date: Wed, 11 Mar 2026 13:35:22 +1000 Message-ID: In-Reply-To: <20260310-sahara_protocol_new_v2-v3-1-994ea4b0d5ad@oss.qualcomm.com> References: <20260310-sahara_protocol_new_v2-v3-0-994ea4b0d5ad@oss.qualcomm.com> <20260310-sahara_protocol_new_v2-v3-1-994ea4b0d5ad@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This adds a 1241-line protocol specification document under `Documentation/sahara/`. The documentation is extensive and well-structured. **Issues:** - The `Documentation/sahara/` directory is not integrated into the top-level documentation toctree. Without an entry in a parent `index.rst`, Sphinx will not discover these files during `make htmldocs`, producing orphan warnings or simply omitting them from the generated documentation. - The commit message subject should follow the conventional kernel format `Documentation: sahara: Add Sahara protocol documentation` rather than the generic "Add documentation for Sahara protocol." --- Generated by Claude Code Patch Reviewer