From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/prime: Limit scatter list size with dedicated DMA device Date: Wed, 11 Mar 2026 13:45:58 +1000 Message-ID: In-Reply-To: <20260310032511.2545500-2-wenst@chromium.org> References: <20260310032511.2545500-1-wenst@chromium.org> <20260310032511.2545500-2-wenst@chromium.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review A straightforward one-liner that changes `dev->dev` to `drm_dev_dma_dev(dev)` in `drm_prime_pages_to_sg()`: ```c - max_segment = dma_max_mapping_size(dev->dev); + max_segment = dma_max_mapping_size(drm_dev_dma_dev(dev)); ``` This is correct. When a dedicated DMA device is set, the DMA mapping size limit should come from that device, not the parent device (which may not even be DMA-capable). Since `drm_dev_dma_dev()` falls back to `dev->dev` when no dedicated device is set, this is safe for all existing callers. No issues with this patch. --- Generated by Claude Code Patch Reviewer