From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: remoteproc: qcom, sm8550-pas: Add Glymur ADSP
Date: Wed, 11 Mar 2026 13:43:35 +1000 [thread overview]
Message-ID: <review-patch1-20260310033617.3108675-2-sibi.sankar@oss.qualcomm.com> (raw)
In-Reply-To: <20260310033617.3108675-2-sibi.sankar@oss.qualcomm.com>
Patch Review
**Looks correct.** Adds `qcom,glymur-adsp-pas` as a compatible that falls back to `qcom,sm8550-adsp-pas`, alongside `qcom,kaanapali-adsp-pas` and `qcom,sm8750-adsp-pas`. Also adds it to the `allOf` `contains` block that constrains interrupts to 6 and memory-region to 2, which matches the DTS in patch 4 (6 interrupts including "shutdown-ack", 2 memory regions).
No issues found.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-11 3:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 3:36 [PATCH V4 0/5] Enable ADSP and CDSP for Glymur SoC Sibi Sankar
2026-03-10 3:36 ` [PATCH V4 1/5] dt-bindings: remoteproc: qcom, sm8550-pas: Add Glymur ADSP Sibi Sankar
2026-03-10 7:50 ` [PATCH V4 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: " Krzysztof Kozlowski
2026-03-10 9:17 ` Sibi Sankar
2026-03-11 3:43 ` Claude Code Review Bot [this message]
2026-03-10 3:36 ` [PATCH V4 2/5] dt-bindings: remoteproc: qcom, sm8550-pas: Add Glymur CDSP Sibi Sankar
2026-03-11 3:43 ` Claude review: " Claude Code Review Bot
2026-03-10 3:36 ` [PATCH V4 3/5] dt-bindings: misc: qcom, fastrpc: Add compatible for Glymur Sibi Sankar
2026-03-10 7:52 ` [PATCH V4 3/5] dt-bindings: misc: qcom,fastrpc: " Krzysztof Kozlowski
2026-03-11 3:43 ` Claude review: dt-bindings: misc: qcom, fastrpc: " Claude Code Review Bot
2026-03-10 3:36 ` [PATCH V4 4/5] arm64: dts: qcom: glymur: Add ADSP and CDSP for Glymur SoC Sibi Sankar
2026-03-11 3:43 ` Claude review: " Claude Code Review Bot
2026-03-10 3:36 ` [PATCH V4 5/5] arm64: dts: qcom: glymur-crd: Enable ADSP and CDSP Sibi Sankar
2026-03-11 3:43 ` Claude review: " Claude Code Review Bot
2026-03-11 3:43 ` Claude review: Enable ADSP and CDSP for Glymur SoC Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-13 12:08 [PATCH V5 0/5] " Sibi Sankar
2026-03-13 12:08 ` [PATCH V5 1/5] dt-bindings: remoteproc: qcom, sm8550-pas: Add Glymur ADSP Sibi Sankar
2026-03-13 21:07 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260310033617.3108675-2-sibi.sankar@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox